Skip to content

style: include UC_USELESS_OBJECT #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2024

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Apr 29, 2024

This PR includes the UC_USELESS_OBJECT SpotBugs rule. The removed App class was redundant.

Related to #5122.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.36%. Comparing base (2513ccd) to head (01671cb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5127      +/-   ##
============================================
+ Coverage     37.34%   37.36%   +0.02%     
  Complexity     2350     2350              
============================================
  Files           517      517              
  Lines         15622    15618       -4     
  Branches       2971     2971              
============================================
+ Hits           5834     5836       +2     
+ Misses         9500     9495       -5     
+ Partials        288      287       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vil02 vil02 force-pushed the include_UC_USELESS_OBJECT branch from d7ffeae to 9abbd06 Compare April 29, 2024 16:59
@vil02 vil02 marked this pull request as ready for review April 29, 2024 17:01
@vil02 vil02 enabled auto-merge (squash) April 29, 2024 19:09
Copy link
Member

@BamaCharanChhandogi BamaCharanChhandogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@vil02 vil02 force-pushed the include_UC_USELESS_OBJECT branch from 9abbd06 to 01671cb Compare May 1, 2024 10:55
@vil02 vil02 force-pushed the include_UC_USELESS_OBJECT branch from 01671cb to 78287f4 Compare May 1, 2024 11:09
@vil02 vil02 merged commit f64bc3c into TheAlgorithms:master May 1, 2024
4 checks passed
@vil02 vil02 deleted the include_UC_USELESS_OBJECT branch May 1, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants